deniskuzZ commented on code in PR #6642:
URL: https://github.com/apache/hive/pull/6642#discussion_r3764600600


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java:
##########
@@ -447,8 +447,10 @@ private String validateTransactionalProperties(String 
transactionalProperties) {
   /**
    * see org.apache.hadoop.hive.ql.exec.Utilities#COPY_KEYWORD
    */
+  // Copy suffix is either a numeric counter (HDFS/local: _copy_N) or a 16-hex 
per-query
+  // uniqueness tag (non-atomic-rename FS such as S3A: _copy_<queryTag>).
   private static final Pattern ORIGINAL_PATTERN_COPY =
-    Pattern.compile("[0-9]+_[0-9]+" + "_copy_" + "[0-9]+");
+      Pattern.compile("[0-9]+_[0-9]+" + "_copy_" + 
"(?:[0-9]{1,6}|[0-9a-fA-F]{16})");

Review Comment:
   is this the same as in `AcidUtils`? could we reuse?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to