deniskuzZ commented on code in PR #6680:
URL: https://github.com/apache/hive/pull/6680#discussion_r3764619563
##########
ql/src/java/org/apache/hadoop/hive/ql/io/SkippingTextInputFormat.java:
##########
@@ -78,6 +79,10 @@ private FileSplit makeSplitInternal(Path file, long start,
long length, String[]
} catch (IOException e) {
LOG.warn("Could not detect header/footer", e);
return new NullRowsInputFormat.DummyInputSplit(file);
+ } catch (RuntimeException e) {
+ // Report unexpected detection failures clearly instead of a cryptic
cast.
+ throw new RuntimeException("Failed to detect header/footer boundaries
for file "
Review Comment:
i don't see much benefit in re-throwing same runtime exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
