deniskuzZ commented on code in PR #6679:
URL: https://github.com/apache/hive/pull/6679#discussion_r3767149884


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -985,18 +984,27 @@ public void addDynamicPartitions(AddDynamicPartitions 
rqst) throws NoSuchTxnExce
    */
   @Override
   public void cleanupRecords(HiveObjectType type, Database db, Table table,
-        Iterator<Partition> partitionIterator, boolean 
keepTxnToWriteIdMetaData) throws MetaException {
-    new CleanupRecordsFunction(type, db, table, partitionIterator, 
getDefaultCatalog(conf), keepTxnToWriteIdMetaData, null)
-        .execute(jdbcResource);
+        Iterator<String> partNamesIterator, boolean keepTxnToWriteIdMetaData) 
throws MetaException {

Review Comment:
   not sure it's ok to change the interface here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to