Aggarwal-Raghav commented on code in PR #6681: URL: https://github.com/apache/hive/pull/6681#discussion_r3790196829
########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/udf/GenericUDTFIcebergAncestorsOf.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive.udf; + +import java.util.List; +import org.apache.hadoop.hive.common.type.Timestamp; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.ql.exec.Description; +import org.apache.hadoop.hive.ql.exec.UDFArgumentException; +import org.apache.hadoop.hive.ql.metadata.Hive; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.session.SessionState; +import org.apache.hadoop.hive.ql.udf.UDFType; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDTF; +import org.apache.hadoop.hive.serde2.objectinspector.ConstantObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorFactory; +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils; +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.primitive.LongObjectInspector; +import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; +import org.apache.hadoop.hive.serde2.objectinspector.primitive.StringObjectInspector; +import org.apache.iceberg.SerializableTable; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.Table; +import org.apache.iceberg.mr.hive.IcebergTableUtil; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.util.SerializationUtil; +import org.apache.iceberg.util.SnapshotUtil; + +@Description( + name = "iceberg_ancestors_of", + value = + """ + _FUNC_(tableName, [snapshotId]) - Returns a table of all ancestors of the \ + specified snapshot (or the current snapshot if omitted) for the given Iceberg table.""", + extended = + """ + Example: + > SELECT * FROM _FUNC_('default.my_iceberg_table'); + > SELECT * FROM _FUNC_('default.my_iceberg_table', 123456789012345); + + Note: This function should generally be used in a standalone SELECT query. + If you include a FROM clause without restricting the input rows (e.g. LIMIT 1), + the UDTF will be evaluated for every row in the source table, causing multiplied output. + """) +@UDFType(deterministic = false) +public class GenericUDTFIcebergAncestorsOf extends GenericUDTF { + + private transient LongObjectInspector snapshotIdOI; + private final transient Object[] forwardObj = new Object[2]; + + private String serializedTable; + private transient Table icebergTable; + + @Override + public StructObjectInspector initialize(ObjectInspector[] args) throws UDFArgumentException { + if (args.length < 1 || args.length > 2) { + throw new UDFArgumentException( + "iceberg_ancestors_of takes 1 or 2 arguments: tableName (string) and optional snapshotId (long)."); + } + + if (!(args[0] instanceof StringObjectInspector)) { + throw new UDFArgumentException("The first argument (tableName) must be a string."); + } + + if (args.length == 2) { + if (!(args[1] instanceof LongObjectInspector)) { + throw new UDFArgumentException("The second argument (snapshotId) must be a long."); + } + snapshotIdOI = (LongObjectInspector) args[1]; + } + + loadIcebergTable(args); + + List<String> fieldNames = Lists.newArrayList(); + List<ObjectInspector> fieldOIs = Lists.newArrayList(); + + fieldNames.add("snapshot_id"); + fieldOIs.add(PrimitiveObjectInspectorFactory.javaLongObjectInspector); + + fieldNames.add("timestamp"); + fieldOIs.add(PrimitiveObjectInspectorFactory.javaTimestampObjectInspector); + + return ObjectInspectorFactory.getStandardStructObjectInspector(fieldNames, fieldOIs); + } + + private void loadIcebergTable(ObjectInspector[] args) throws UDFArgumentException { + if (SessionState.get() != null && ObjectInspectorUtils.isConstantObjectInspector(args[0])) { + String tableNameStr = + ((ConstantObjectInspector) args[0]).getWritableConstantValue().toString(); + try { + HiveConf hiveConf = SessionState.getSessionConf(); + org.apache.hadoop.hive.ql.metadata.Table hiveTable = + Hive.get(hiveConf).getTable(tableNameStr); + Table table = IcebergTableUtil.getTable(hiveConf, hiveTable.getTTable()); + + this.serializedTable = SerializationUtil.serializeToBase64(SerializableTable.copyOf(table)); Review Comment: Serialization to Base64 is explicitly done because of this kryo5 error ``` Caused by: org.apache.hive.com.esotericsoftware.kryo.kryo5.KryoException: java.lang.UnsupportedOperationException: can't get field offset on a hidden class: private final org.apache.iceberg.mr.hive.HiveTableUtil$NonSerializingConfig org.apache.iceberg.mr.hive.HiveTableUtil$$Lambda/0x0000000801d8ec70.arg$1 Serialization trace: hadoopConf (org.apache.iceberg.hadoop.HadoopFileIO) io (org.apache.iceberg.SerializableTable) icebergTable (org.apache.iceberg.mr.hive.udf.GenericUDTFIcebergAncestorsOf) genericUDTF (org.apache.hadoop.hive.ql.plan.UDTFDesc) conf (org.apache.hadoop.hive.ql.exec.UDTFOperator) childOperators (org.apache.hadoop.hive.ql.exec.SelectOperator) childOperators (org.apache.hadoop.hive.ql.exec.LimitOperator) reducer (org.apache.hadoop.hive.ql.plan.ReduceWork) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:102) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CollectionSerializer.write(CollectionSerializer.java:155) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CollectionSerializer.write(CollectionSerializer.java:44) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CollectionSerializer.write(CollectionSerializer.java:155) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CollectionSerializer.write(CollectionSerializer.java:44) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:642) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:71) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.write(FieldSerializer.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeObject(Kryo.java:627) at org.apache.hadoop.hive.ql.exec.SerializationUtilities.serializeObjectByKryo(SerializationUtilities.java:833) at org.apache.hadoop.hive.ql.exec.SerializationUtilities.serializePlan(SerializationUtilities.java:720) at org.apache.hadoop.hive.ql.exec.Utilities.setBaseWork(Utilities.java:595) ... 31 more Caused by: java.lang.UnsupportedOperationException: can't get field offset on a hidden class: private final org.apache.iceberg.mr.hive.HiveTableUtil$NonSerializingConfig org.apache.iceberg.mr.hive.HiveTableUtil$$Lambda/0x0000000801d8ec70.arg$1 at jdk.unsupported/sun.misc.Unsafe.objectFieldOffset(Unsafe.java:652) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.UnsafeField.<init>(UnsafeField.java:38) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CachedFields.newUnsafeField(CachedFields.java:211) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CachedFields.addField(CachedFields.java:156) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.CachedFields.rebuild(CachedFields.java:99) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.FieldSerializer.<init>(FieldSerializer.java:82) at org.apache.hive.com.esotericsoftware.kryo.kryo5.SerializerFactory$FieldSerializerFactory.newSerializer(SerializerFactory.java:124) at org.apache.hive.com.esotericsoftware.kryo.kryo5.SerializerFactory$FieldSerializerFactory.newSerializer(SerializerFactory.java:108) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.newDefaultSerializer(Kryo.java:469) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.getDefaultSerializer(Kryo.java:454) at org.apache.hive.com.esotericsoftware.kryo.kryo5.util.DefaultClassResolver.registerImplicit(DefaultClassResolver.java:89) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.getRegistration(Kryo.java:581) at org.apache.hadoop.hive.ql.exec.SerializationUtilities$KryoWithHooks.getRegistration(SerializationUtilities.java:250) at org.apache.hive.com.esotericsoftware.kryo.kryo5.util.DefaultClassResolver.writeClass(DefaultClassResolver.java:112) at org.apache.hive.com.esotericsoftware.kryo.kryo5.Kryo.writeClass(Kryo.java:613) at org.apache.hive.com.esotericsoftware.kryo.kryo5.serializers.ReflectField.write(ReflectField.java:68) ... 63 more ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
