rubenada commented on code in PR #6523:
URL: https://github.com/apache/hive/pull/6523#discussion_r3823222135
##########
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out:
##########
@@ -581,10 +581,10 @@ STAGE PLANS:
Map Operator Tree:
TableScan
alias: srcpart
- filterExpr: CAST( ds AS DATE) is not null (type: boolean)
+ filterExpr: day(CAST( ds AS DATE)) is not null (type:
boolean)
Review Comment:
I think we should create a ticket on Hive side to "override the
isSafeOperator method on Hive operators that are safe".
I would not treat this on Calcite side, EXTRACT operator seems to be used
for a wide range of cases, I'm not sure if we can consider it "safe" 100%.
UPDATE: I have double-checked, indeed SqlKind.EXTRACT is used on Calcite
also for operators that allow a string operand, so I guess it cannot be
considered "safe" (since it can throw at runtime in these cases when a
malformed string is passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
