Manya0407 commented on code in PR #6656:
URL: https://github.com/apache/hive/pull/6656#discussion_r3893348477
##########
service/src/java/org/apache/hive/http/LlapServlet.java:
##########
@@ -100,6 +100,8 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response) {
ExitCode ret =
driver.run(LlapStatusServiceCommandLine.parseArguments(new String[] {"-n",
clusterName}), 0);
if (ret == ExitCode.SUCCESS) {
driver.outputJson(writer);
+ } else {
+ response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
}
Review Comment:
Added Cache-Control: no-store on the error path so proxies don’t cache
failed status responses.
##########
llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java:
##########
@@ -225,30 +241,35 @@ public ExitCode run(LlapStatusServiceCommandLine cl, long
watchTimeoutMs) {
if (ret != ExitCode.SUCCESS) {
return ret;
- } else if
(NO_YARN_SERVICE_INFO_STATES.contains(appStatusBuilder.getState())) {
+ }
+
+ if (NO_YARN_SERVICE_INFO_STATES.contains(appStatusBuilder.getState())) {
+ updateRunningThresholdAchieved(appStatusBuilder,
cl.getRunningNodesThreshold());
Review Comment:
Call was a no-op here since the method only acts on
RUNNING_PARTIAL/RUNNING_ALL. Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
