deniskuzZ commented on code in PR #6701: URL: https://github.com/apache/hive/pull/6701#discussion_r3893807727
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/WriterBuilder.java:
##########
@@ -73,6 +73,7 @@ public class WriterBuilder {
private TaskAttemptID attemptID;
private String queryId;
private Operation operation;
Review Comment:
should we rename to writeOperation for consistency
````
// WriterBuilder
private Operation writeOperation;
// was: operation
this.writeOperation = HiveCustomStorageHandlerUtils.getWriteOperation(ops,
tableName);
public WriterBuilder writeOperation(Operation newWriteOperation) {
// was: operation(...)
this.writeOperation = newWriteOperation;
return this;
}
boolean isCOW = IcebergTableUtil.isCopyOnWriteMode(
ObjectUtils.defaultIfNull(statementOperation, writeOperation),
table.properties()::getOrDefault);
writer = switch (writeOperation) { ... }
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
