Aggarwal-Raghav commented on code in PR #6744:
URL: https://github.com/apache/hive/pull/6744#discussion_r3916816319


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/filtercontext/DatabaseFilterContext.java:
##########
@@ -89,7 +89,7 @@ private List<HivePrivilegeObject> getInputHObjs() {
       if (db != null) {
         ret.add(getHivePrivilegeObject(db));
       } else {
-        HivePrivilegeObject hivePrivilegeObject = new 
HivePrivilegeObject(type, dbName);
+        HivePrivilegeObject hivePrivilegeObject = new 
HivePrivilegeObject(type, catName, dbName, dbName);

Review Comment:
   In L90, when DB != null,  `getHivePrivilegeObject(db)` we are setting (type, 
catlaog, db, null). So in fix I think 4th param should be null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to