Aggarwal-Raghav commented on code in PR #6618: URL: https://github.com/apache/hive/pull/6618#discussion_r3923063667
########## Jenkinsfile: ########## @@ -97,8 +97,9 @@ sw java 21 && . /etc/profile.d/java.sh mkdir -p .m2/repository cp $SETTINGS .m2/settings.xml OPTS=" -s $PWD/.m2/settings.xml -B -Dtest.groups= " -OPTS+=" -Pitests,qsplits,dist,errorProne" +OPTS+=" -Pitests,qsplits,dist,errorProne,thriftif" OPTS+=" -Dmaven.repo.local=$PWD/.m2/repository" +OPTS+=" -Dthrift.home=/work/thrift-0.16.0" Review Comment: nit: should we put a comment in parent pom.xml along the lines, "update the version in Jenkinsfile" `<libthrift.version>0.16.0</libthrift.version>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
