deniskuzZ commented on code in PR #6747:
URL: https://github.com/apache/hive/pull/6747#discussion_r3925144508
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java:
##########
@@ -212,8 +234,10 @@ private static VectorizedRowBatchCtx
createVrbCtx(StructObjectInspector oi, fina
.HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_ENABLED).equalsIgnoreCase("decimal_64");
final String serde =
tblProps.getProperty(serdeConstants.SERIALIZATION_LIB);
final String inputFormat =
tblProps.getProperty(hive_metastoreConstants.FILE_INPUT_FORMAT);
- final boolean isTextFormat = inputFormat != null &&
inputFormat.equals(TextInputFormat.class.getName()) &&
- serde != null && serde.equals(LazySimpleSerDe.class.getName());
+ final boolean isTextFormat = inputFormat != null &&
inputFormat.equals(TextInputFormat.class.getName())
Review Comment:
can we reverse and compare constants with vars, can skip null checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
