sercanCyberVision commented on PR #6775: URL: https://github.com/apache/hive/pull/6775#issuecomment-5698312517
Hi @tanishq-chugh, thank you for taking a look at this PR. You are right that dependencies coming from the root Hive project should use `hive.version`, and that `hive.version` in the `standalone-metastore` POM should not point to `project.version` so that packaging separately could work as intended. I have corrected this. However, the reason I thought there was an issue and decided to create this PR is a little different. The same dependency under `standalone-metastore` is currently configured with two different version properties. For example, `hive-standalone-metastore-common` is configured with `project.version` inside [standalone-metastore/metastore-client/pom.xml](https://github.com/apache/hive/blob/bfe74f9b3f92188095d50cf103b86431f8aaa821/standalone-metastore/metastore-client/pom.xml#L35), while the same dependency uses `hive.version` in [standalone-metastore/metastore-rest-catalog/pom.xml](https://github.com/apache/hive/blob/b88f9481fbc6ab1bc892607876d821f5a25ca396/standalone-metastore/metastore-rest-catalog/pom.xml#L43). The modified solution only changes internal `standalone-metastore` module dependencies that use `hive.version` instead of `project.version`. Could you please take another look at the modified solution? If my understanding is still not right, please feel free to close the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
