kasakrisz commented on PR #4492: URL: https://github.com/apache/hive/pull/4492#issuecomment-5713439855
> > What I am trying to understand is to what extend the restrictions imposed by `hasOuterJoin` are relevant. > > @zabetak, unfortunately, I can't provide answer to that question. @kasakrisz reviewed one of the PRs, maybe he has a better picture on that @deniskuzZ @zabetak The logic implemented in `hasOuterJoin` was originally introduced in [HIVE-9038](https://issues.apache.org/jira/browse/HIVE-9038). It was reverted in that same issue, but later brought back by [HIVE-9414](https://issues.apache.org/jira/browse/HIVE-9414). HIVE-9038 mentions Tez test failures as the reason why this restriction is needed when converting an outer join to a map join. However, Hive has been using Tez + LLAP as the default test driver, and those tests have been passing for a long time. This makes me wonder if the `hasOuterJoin` method is even necessary in the first place? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
