deniskuzZ commented on code in PR #6732:
URL: https://github.com/apache/hive/pull/6732#discussion_r4060315783
##########
common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java:
##########
@@ -228,31 +228,39 @@ protected void doPost(final HttpServletRequest request,
final HttpServletRespons
}
private void configureLogger(final ConfLoggers confLoggers) {
- if (confLoggers != null) {
- for (ConfLogger logger : confLoggers.getLoggers()) {
- String loggerName = logger.getLogger();
- Level logLevel = Level.getLevel(logger.getLevel());
- if (logLevel == null) {
- LOG.warn("Invalid log level: {} for logger: {}. Ignoring
reconfiguration.", loggerName, logger.getLevel());
- continue;
- }
-
- LoggerConfig loggerConfig = conf.getLoggerConfig(loggerName);
- // if the logger name is not found, root logger is returned. We don't
want to change root logger level
- // since user either requested a new logger or specified invalid
input. In which, we will add the logger
- // that user requested.
- if (!loggerName.equals(LogManager.ROOT_LOGGER_NAME) &&
- loggerConfig.getName().equals(LogManager.ROOT_LOGGER_NAME)) {
- LOG.debug("Requested logger ({}) not found. Adding as new logger
with {} level", loggerName, logLevel);
- // requested logger not found. Add the new logger with the requested
level
- conf.addLogger(loggerName, new LoggerConfig(loggerName, logLevel,
true));
- } else {
- LOG.debug("Updating logger ({}) to {} level", loggerName, logLevel);
- // update the log level for the specified logger
- loggerConfig.setLevel(logLevel);
- }
+ if (confLoggers == null) {
+ return;
+ }
+ for (ConfLogger logger : confLoggers.getLoggers()) {
+ String loggerName = logger.getLogger();
+ Level logLevel = Level.getLevel(logger.getLevel());
+ if (logLevel == null) {
+ LOG.warn("Invalid log level: {} for logger: {}. Ignoring
reconfiguration.", logger.getLevel(), loggerName);
+ continue;
}
- context.updateLoggers(conf);
+ setLogLevel(loggerName, logLevel);
Review Comment:
why extract?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
