deniskuzZ commented on code in PR #6578:
URL: https://github.com/apache/hive/pull/6578#discussion_r4081758282
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java:
##########
@@ -2042,12 +2161,20 @@ private static ParquetDataColumnReader
getConvertorFromBinary(boolean isDict,
int hiveScale =
(typeName.equalsIgnoreCase(serdeConstants.DECIMAL_TYPE_NAME)) ?
((DecimalTypeInfo) realHiveType).getScale() : 0;
+ LogicalTypeAnnotation logicalType = parquetType.getLogicalTypeAnnotation();
+
if (logicalType == null) {
- return isDict ? new DefaultParquetDataColumnReader(dictionary, length) :
new
- DefaultParquetDataColumnReader(valuesReader, length);
+ // Check if we need to convert the string into a specific Hive type
(like DATE)
+ ParquetDataColumnReader reader =
+ getReaderForString(realHiveType, isDict, dictionary, valuesReader,
length);
+ return reader != null
+ ? reader
Review Comment:
formatting seems to be off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
