difin commented on code in PR #6789:
URL: https://github.com/apache/hive/pull/6789#discussion_r4135749861
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -343,6 +344,10 @@ public void commitJob(JobContext originalContext) {
public void configureJobConf(TableDesc tableDesc, JobConf jobConf) {
setCommonJobConf(jobConf);
configureOutputTableJobConf(tableDesc, jobConf);
+ if (tableDesc != null && tableDesc.getProperties() != null) {
+ String catalogName =
tableDesc.getProperties().getProperty(InputFormatConfig.CATALOG_NAME);
Review Comment:
If we move this to If we move this ti tableDesc we will add Iceberg-specific
code to hive-exec module.
How about `tableDesc.getProperty(InputFormatConfig.CATALOG_NAME)` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]