illiabarbashov-sketch commented on code in PR #6748: URL: https://github.com/apache/hive/pull/6748#discussion_r4154124231
########## schematool/pom.xml: ########## @@ -0,0 +1,125 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.hive</groupId> + <artifactId>hive</artifactId> + <version>4.3.0-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + <artifactId>hive-schematool</artifactId> Review Comment: schematool overrides `execSql()` and uses beeline functionality. Now we want to reduce beeline size as much as it can, so that's why we decided to move schema tool into a separate module. But, `hive-service` depends on `hive-metastore` and beeline depends on `hive-service`. If schematool goes to `hive-metastore` there will be maven module cyclic dependency which are not allowed. I would suggest either leave schematool as a separate tiny module since refactoring doesn't seem to be feasible at this point. Resolving that cyclic dependency might need some heavy lift class rearrangments, which I think is outside of the scope of this task. What thoughts do you have guys? @dengzhhu653 @deniskuzZ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
