deniskuzZ commented on code in PR #6856:
URL: https://github.com/apache/hive/pull/6856#discussion_r4241228899
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogAdapter.java:
##########
@@ -378,7 +379,12 @@ private RESTResponse tableExists(Map<String, String> vars)
{
private LoadTableResponse loadTable(Map<String, String> vars) {
TableIdentifier ident = identFromPathVars(vars);
- return CatalogHandlers.loadTable(catalog, ident);
+ String snapshots =
vars.get(RESTCatalogProperties.SNAPSHOTS_QUERY_PARAMETER);
+ RESTCatalogProperties.SnapshotMode mode =
RESTCatalogProperties.SNAPSHOT_LOADING_MODE_DEFAULT;
+ if (snapshots != null) {
+ mode =
RESTCatalogProperties.SnapshotMode.valueOf(snapshots.toUpperCase(Locale.ROOT));
Review Comment:
do we have any tests for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
