ramitg254 commented on code in PR #6861:
URL: https://github.com/apache/hive/pull/6861#discussion_r4255999719
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFOperator.java:
##########
@@ -435,10 +435,11 @@ private void initBufferedColumns() {
* 1. order columns
* 2. the non-key input columns
* 3. any streaming columns that will already have their output values
- * 4. scratch columns (as they're used by input expressions of evaluators)
+ * 4. scratch columns holding the results of evaluator input expressions
*/
+ final int[] bufferedScratchIndices = getEvaluatorInputScratchIndices();
Review Comment:
change makes sense, I know I am asking too much but can you please remove
workaround added in these files:
ql/src/test/queries/clientpositive/sketches_rewrite_cume_dist.q
ql/src/test/queries/clientpositive/sketches_rewrite_cume_dist_partition_by.q
in this change
https://github.com/apache/hive/pull/6703/changes#diff-e03a7feea22c2de54e39d2a81840303b5fd18d4bdfdf15be9af2eab68984f5cb
it should also pass now without that workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
