deniskuzZ commented on code in PR #6862:
URL: https://github.com/apache/hive/pull/6862#discussion_r4272434916
##########
iceberg/iceberg-handler/src/test/queries/positive/iceberg_v2_deletes.q:
##########
@@ -1,93 +0,0 @@
--- Mask random uuid
---! qt:replace:/(\s+'uuid'=')\S+('\s*)/$1#Masked#$2/
--- Mask a random snapshot id
---! qt:replace:/(\s\'current-snapshot-id\'=\')(\d+)(\')/$1#Masked#$3/
--- Mask added file size
---! qt:replace:/(\S+\"added-files-size\":\")(\d+)(\")/$1#Masked#$3/
--- Mask total file size
---! qt:replace:/(\S+\"total-files-size\":\")(\d+)(\")/$1#Masked#$3/
--- Mask current-snapshot-timestamp-ms
---! qt:replace:/(\s\'current-snapshot-timestamp-ms\'=\')(\d+)(\')/$1#Masked#$3/
--- Mask iceberg version
---!
qt:replace:/("iceberg-version":")(\w+\s\w+\s\d+\.\d+\.\d+\s\(\w+\s\w+\))/$1#Masked#/
-
--- create an unpartitioned table with skip delete data set to false
- create table ice01 (id int) Stored by Iceberg stored as ORC
Review Comment:
why remove tests for v2 deletes? could we do
https://github.com/deniskuzZ/hive/commit/7813aa88e696ced26fe25a83bd2812bfebf992b8#diff-41098d635c48fd16c932b146dc0d2f1ffaa9ed3ccb833c29295d1863b7bb7fff
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
