myg821561935 commented on PR #6631: URL: https://github.com/apache/hive/pull/6631#issuecomment-6332166488
@dengzhhu653 I checked this against master at `1a00fcbdcf3aadf54f801f6e85afff569f95eb70`. You were right about HIVE-25918. Both statistics-reload control tests pass without this patch, even with a stale partition object whose create time is zero. I have corrected the PR description; I am not claiming that the original Hive 3.1.2 statistics-update case still reproduces on master. Two separate cases do reproduce: the single and dynamic load APIs return a zero create time when using remote HMS, and direct alter/rename requests can overwrite a stored create time with zero or a negative value. The old QL tests used embedded HMS and passed without the patch, so I replaced them with remote-HMS tests. Without the patch, the two load-return tests fail, as do 18 alter/rename cases across embedded and remote HMS. With it, all four remote-HMS tests and all 174 alter tests pass. Explicit positive create times remain supported. The existing load tests and temporary-table regression suite also pass; the HMS-only assertions are excluded for temporary tables. The 23-module clean build passed with JDK 21.0.7. The PR description has the commands and before/after results. These checks exercise the APIs and statistics task directly, rather than a full SQL execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
