Manya0407 commented on PR #6656: URL: https://github.com/apache/hive/pull/6656#issuecomment-6359578123
> Was trying out the llapstatus CLI with this patch, and came across this NPE : > > ``` > SLF4J: Class path contains multiple SLF4J bindings. > SLF4J: Found binding in [jar:file:/opt/hive/lib/log4j-slf4j-impl-2.26.1.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: Found binding in [jar:file:/opt/hadoop/share/hadoop/common/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] > SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. > SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] > LLAP status invoked with arguments = [-n, non_existent_cluster, --hiveconf, hive.llap.daemon.service.hosts=@llap0] > LLAP status running with the following parsed arguments: > name : non_existent_cluster > findAppTimeoutMs : 20000 > outputFile : null > watchMode : false > isLaunched : true > runningNodesThreshold: 1.0 > refreshIntervalMs : 1000 > watchTimeoutMs : 300000 > hiveConf : {hive.llap.daemon.service.hosts=@llap0=true} > WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable > WARN status.LlapStatusServiceDriver: Failed to log summary > java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.hive.llap.cli.status.AmInfo.getAppId()" because the return value of "org.apache.hadoop.hive.llap.cli.status.AppStatusBuilder.getAmInfo()" is null > at org.apache.hadoop.hive.llap.cli.status.LlapStatusServiceDriver.constructDiagnostics(LlapStatusServiceDriver.java:839) > at org.apache.hadoop.hive.llap.cli.status.LlapStatusServiceDriver.maybeLogSummary(LlapStatusServiceDriver.java:809) > at org.apache.hadoop.hive.llap.cli.status.LlapStatusServiceDriver.main(LlapStatusServiceDriver.java:680) > ERROR status.LlapStatusServiceDriver: FAILED: Cannot invoke "org.apache.hadoop.hive.llap.cli.status.AmInfo.getAppId()" because the return value of "org.apache.hadoop.hive.llap.cli.status.AppStatusBuilder.getAmInfo()" is null > java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.hive.llap.cli.status.AmInfo.getAppId()" because the return value of "org.apache.hadoop.hive.llap.cli.status.AppStatusBuilder.getAmInfo()" is null > at org.apache.hadoop.hive.llap.cli.status.LlapStatusServiceDriver.constructDiagnostics(LlapStatusServiceDriver.java:839) > at org.apache.hadoop.hive.llap.cli.status.LlapStatusServiceDriver.maybeLogSummary(LlapStatusServiceDriver.java:809) > at org.apache.hadoop.hive.llap.cli.status.LlapStatusServiceDriver.main(LlapStatusServiceDriver.java:763) > FAILED: Cannot invoke "org.apache.hadoop.hive.llap.cli.status.AmInfo.getAppId()" because the return value of "org.apache.hadoop.hive.llap.cli.status.AppStatusBuilder.getAmInfo()" is null > ERROR status.LlapStatusServiceDriver: LLAP did not start. Check the application log for more info: > yarn logs --applicationId null -out <path> > bash-5.1$ > ``` > > Was checking the case where llap cluster of which the status is being checked does not exist / not found. Could you please check on this ? The summary logger already assumed amInfo exists for LAUNCHING, but my new registry-only path made LAUNCHING without amInfo reachable when the registry has no instances. If its to be handled this in this PR - would you prefer the minimal fix of initializing AmInfo in the empty-registry branch, or should I also make the pre-existing constructDiagnostics() path null-safe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
