abstractdog commented on code in PR #6724:
URL: https://github.com/apache/hive/pull/6724#discussion_r4387666870
##########
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemon.java:
##########
@@ -106,7 +106,7 @@ public void testEnforceProperNumberOfIOThreads() throws
IOException {
HiveConf.setIntVar(hiveConf, HiveConf.ConfVars.LLAP_IO_THREADPOOL_SIZE, 3);
daemon = new LlapDaemon(hiveConf, 4, LlapDaemon.getTotalHeapSize(), true,
false,
- -1, new String[1], 0, false, 0,0, 0, defaultWebPort,
"TestLlapDaemon");
+ -1, new String[1], 0,0, 0, defaultWebPort, "TestLlapDaemon");
Review Comment:
nit: fix formatting here also to: `0, 0, 0,`
##########
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java:
##########
@@ -643,8 +623,8 @@ public static void main(String[] args) throws Exception {
LlapDaemon.initializeLogging(daemonConf);
llapDaemon =
new LlapDaemon(daemonConf, numExecutors, executorMemoryBytes,
isLlapIo, isDirectCache,
- ioMemoryBytes, localDirs, rpcPort,
externalClientCloudSetupEnabled,
- externalClientCloudRpcPort, mngPort, shufflePort, webPort,
appName);
+ ioMemoryBytes, localDirs, rpcPort,
+ mngPort, shufflePort, webPort, appName);
Review Comment:
nit: these now can fit into a single line maybe
##########
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java:
##########
@@ -95,7 +97,7 @@ private enum TokenRequiresSigning {
public LlapProtocolServerImpl(SecretManager secretManager, int numHandlers,
ContainerRunner containerRunner, AtomicReference<InetSocketAddress>
srvAddress,
- AtomicReference<InetSocketAddress> mngAddress, int srvPort, int
externalClientsRpcPort,
+ AtomicReference<InetSocketAddress> mngAddress, int srvPort,
int mngPort, DaemonId daemonId,
Review Comment:
nit: these now can fit into a single line maybe, like:
`AtomicReference<InetSocketAddress> mngAddress, int srvPort, int mngPort,
DaemonId daemonId,`
##########
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemon.java:
##########
@@ -155,7 +155,7 @@ public void testUpdateRegistration() throws IOException {
int enabledQueue = 2;
daemon = new LlapDaemon(hiveConf, 1, LlapDaemon.getTotalHeapSize(), false,
false,
- -1, new String[1], 0, false, 0,0, 0, defaultWebPort, "TestLlapDaemon");
+ -1, new String[1], 0,0, 0, defaultWebPort, "TestLlapDaemon");
Review Comment:
nit: fix formatting here also to: `0, 0, 0,`
##########
llap-server/src/test/org/apache/hadoop/hive/llap/io/encoded/TestLlapOrcCacheLoader.java:
##########
@@ -37,6 +36,7 @@
import org.apache.hive.common.util.FixedSizedObjectPool;
import org.junit.Before;
import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
Review Comment:
this might introduce Junit5 to a class where other imports imply Junit4
(e.g. org.junit.Before), what keep them in sync (org.junit.Assert, e.g.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
