InvisibleProgrammer commented on code in PR #6893:
URL: https://github.com/apache/hive/pull/6893#discussion_r4390961672
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -93,7 +102,7 @@
* ThriftHttpServlet
*
*/
-public class ThriftHttpServlet extends TServlet {
+public class ThriftHttpServlet extends HttpServlet {
Review Comment:
No, we cannot keep TServlet:
Thrift 0.16.0 used TServlet that extends javax.servlet.http.HttpServlet.
Thrift 0.24.0 uses TServlet extending jakarta.servlet.http.HttpServlet.
If I rewrite the code to TServlet, ThriftCLIService's initServer fails at
```
context.addServlet(new ServletHolder(thriftHttpServlet), httpPath);
```
I couldn't find a make it working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
