DanielZhu58 commented on code in PR #6829:
URL: https://github.com/apache/hive/pull/6829#discussion_r4406433106
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -4196,9 +4200,12 @@ public List<WriteEventInfo>
get_all_write_event_info(GetAllWriteEventInfoRequest
startFunction("get_all_write_event_info");
Exception ex = null;
try {
+ authorizeProxyPrivilege();
List<WriteEventInfo> writeEventInfoList =
getMS().getAllWriteEventInfo(request.getTxnId(),
request.getDbName(), request.getTableName());
- return writeEventInfoList == null ? Collections.emptyList() :
writeEventInfoList;
+ List<WriteEventInfo> filtered =
FilterUtils.filterWriteEventInfoIfEnabled(
Review Comment:
Agreed. I removed the table-level filtering
(FilterUtils.filterWriteEventInfoIfEnabled) and its tests. The API is now
guarded only by authorizeProxyPrivilege(), like get_next_notification and the
other notification APIs. Operators/admins who pass the proxy check get the full
result, and ordinary authenticated users are rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
