deniskuzZ commented on code in PR #6943:
URL: https://github.com/apache/hive/pull/6943#discussion_r4466126080


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/impl/ColStatsStoreImpl.java:
##########
@@ -467,7 +467,7 @@ protected boolean canUseJdoQuery() throws MetaException {
       @Override
       protected Map<String, Map<String, String>> getJdoResult()

Review Comment:
   should we add base class method so we don't need to override in multiple 
places? this code anyways is never called
   ````
   protected T getJdoResult() throws MetaException, NoSuchObjectException,
       InvalidObjectException, InvalidInputException {
     throw new UnsupportedOperationException("This operation is only supported 
by direct SQL");
   }
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to