zabetak commented on code in PR #6953:
URL: https://github.com/apache/hive/pull/6953#discussion_r4563374393
##########
.github/workflows/precommit-image.yml:
##########
@@ -49,23 +49,44 @@ jobs:
uses: actions/checkout@v6
with:
persist-credentials: false
+ # On a PR, HEAD is the PR merged into its target branch, and HEAD^1
is the target branch.
+ fetch-depth: 2
- - name: Check that the tag is not published yet
+ # A published tag is never overwritten. When the tag is published
already, a change of the
+ # Dockerfile needs a new version; any other change (e.g. of this
workflow) does not publish.
+ - name: Check the tag
Review Comment:
Still +1 on the PR but all this tag management check and publish seems
overly complicated. We could adopt a simple timestamp based tagging (eg.
`20261113133625`) and get done with it. This way even in the workflow dispatch
we can remove the inputs and also users and future maintainers do not have to
manually bump the version every time there is a change in the Dockerfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]