slachiewicz commented on PR #6938: URL: https://github.com/apache/hive/pull/6938#issuecomment-6876533345
Inlining `FacebookBase` into `BaseHandler` removes `com.facebook.fb303.FacebookBase` itself, and some `ThriftHiveMetastore.Iface` implementers extend it directly: waggle-dance's [`FederatedHMSHandler`](https://github.com/ExpediaGroup/waggle-dance/blob/main/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/server/FederatedHMSHandler.java) and metacat's [`CatalogThriftHiveMetastore`](https://github.com/Netflix/metacat/blob/master/metacat-thrift/src/main/java/com/netflix/metacat/thrift/CatalogThriftHiveMetastore.java). They would have to re-add libfb303 0.9.3, which brings back its `FacebookService` classes, built for libthrift 0.9.3, next to the 0.24 ones generated from `fb303.thrift`. Could `FacebookBase.java` stay as a source file in metastore-common under its original package, as in [#6653](https://github.com/apache/hive/pull/6653/changes/8aadf78fcb00d69d2bfa307568df68dd63cf5428)? `BaseHandler` can keep extending it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
