abstractdog commented on PR #6959:
URL: https://github.com/apache/hive/pull/6959#issuecomment-6975289407

   > > initial idea: can you please add a unit test that verifies this fix?
   > 
   > Thanks @abstractdog for checking it, in this change I am replacing the 
simple delimeter based splitting in case of source file scenario with 
`getCmdList` which is already getting used in beeline sessions for correctly 
splitting up the queries when multiple of them are provided simultaneously. so 
no separate ut is needed as `getCmdList` splitting is already covered by 
`TestCommands.testGetCmdList`
   
   hm, how do you mean no separate UT is needed, there is an exact failure here 
described as:
   `currently simple delimiter splitting results in parsing exeception in case 
string or comment contains semicolon`
   so if that's issue is present, theoretically, there should be a UT case 
which fails without this patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to