difin commented on code in PR #6927:
URL: https://github.com/apache/hive/pull/6927#discussion_r4622658159


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -539,6 +544,7 @@ public void 
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
           if (transaction != null) {
             transaction.commitTransaction();
           }
+          commitUnknownTypePromotion();

Review Comment:
   Good catch — promotion used to be two commits (transaction first, then 
promotion), so the statement could half-apply if the second failed. It’s now 
one commit: it stages rename/comment/reorder/defaults in a transaction, applies 
the UNKNOWN → type change on that staged metadata, and commits once; on 
conflict it refreshes and re-runs `handleChangeColumn`. Added tests for 
conflict retry and for commit failure leaving schema unchanged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to