busbey commented on a change in pull request #112:
URL: https://github.com/apache/yetus/pull/112#discussion_r445056690
##########
File path: precommit/src/main/shell/test-patch.d/maven.sh
##########
@@ -26,7 +26,7 @@ MAVEN_CUSTOM_REPOS=false
MAVEN_CUSTOM_REPOS_DIR="@@@WORKSPACE@@@/yetus-m2"
MAVEN_DEPENDENCY_ORDER=true
MAVEN_FOUND_ROOT_POM=false
-MAVEN_JAVADOC="javadoc:javadoc"
+MAVEN_JAVADOC_GOALS="javadoc:javadoc"
Review comment:
This should be an array
##########
File path: precommit/src/main/shell/test-patch.d/maven.sh
##########
@@ -109,6 +111,12 @@ function maven_parse_args
delete_parameter "${i}"
MAVEN_DEPENDENCY_ORDER=${i#*=}
;;
+ --mvn-javadoc-goals=*)
+ delete_parameter "${i}"
+ MAVEN_JAVADOC_GOALS=${i#*=}
+ MAVEN_JAVADOC_GOALS=${MAVEN_JAVADOC_GOALS//,/ }
Review comment:
This should use `yetus_comma_to_array`
##########
File path: precommit/src/main/shell/test-patch.d/maven.sh
##########
@@ -335,7 +343,7 @@ function maven_modules_worker
modules_workers "${repostatus}" distclean clean -DskipTests=true
;;
javadoc)
- modules_workers "${repostatus}" javadoc clean javadoc:javadoc
-DskipTests=true
+ modules_workers "${repostatus}" javadoc clean "${MAVEN_JAVADOC_GOALS}"
-DskipTests=true
Review comment:
This should be `"${MAVEN_JAVADOC_GOALS[@]}"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
