aw-was-here commented on a change in pull request #4:
URL:
https://github.com/apache/yetus-test-patch-action/pull/4#discussion_r505929021
##########
File path: action.yml
##########
@@ -86,6 +91,7 @@ runs:
- --excludes=${{ inputs.excludes }}
- --github-token=${{ inputs.githubtoken }}
- --html-report-file=${{ inputs.patchdir }}/report.html
+ - --ignore-unknown-options=true
Review comment:
They are not. `--ignore-unknown-options` allows you to pass options that
test-patch may not know about. `--report-unknown-options` is whether or not
test-patch tells you that unknown options got passed. I debated whether or not
`--report` should auto trigger `--ignore` but felt for now to make `--report`
working dependent upon `--ignore`. This is relatively easy to change later if
we find out it doesn't work very well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
