aw-was-here commented on code in PR #253:
URL: https://github.com/apache/yetus/pull/253#discussion_r853382961
##########
precommit/src/main/shell/plugins.d/shellcheck.sh:
##########
@@ -62,6 +62,7 @@ function shellcheck_precheck
if ! verify_command "shellcheck" "${SHELLCHECK}"; then
add_vote_table_v2 0 shellcheck "" "Shellcheck was not available."
delete_test shellcheck
+ return 0
Review Comment:
Not really. I made this return explicit to match the other prechecks. Being
explicit, it re-enforces that test-patch really shouldn't fail if a particular
tool isn't around and we definitely don't want the rest of the code to continue
since that has a few side-effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
