aw-was-here commented on code in PR #259:
URL: https://github.com/apache/yetus/pull/259#discussion_r858763741
##########
asf-site-src/pom.xml:
##########
@@ -45,74 +45,6 @@
<artifactId>yetus-maven-plugin</artifactId>
<version>${project.version}</version>
<executions>
- <!-- AUTOMATED_EDIT_BEGIN -->
- <execution>
- <id>0.11.1</id>
Review Comment:
Basically yes.
The previous order was basically:
1. Generate inprogress javadocs
2. Generate inprogress apidocs
3. Extract older version archives <- where everything fell apart
4. Create new releasedocs for all versions
5. Run middleman
By moving step 3 to be after step 5, changing the directory to where the
extract should actually live, changing where the inprogress javadoc should
live, and preventing overwriting the "existing" files (i.e., the changelog
info), a big chunk of this hocus pocus goes away entirely.
##########
asf-site-src/pom.xml:
##########
@@ -45,74 +45,6 @@
<artifactId>yetus-maven-plugin</artifactId>
<version>${project.version}</version>
<executions>
- <!-- AUTOMATED_EDIT_BEGIN -->
- <execution>
- <id>0.11.1</id>
Review Comment:
Basically yes.
The previous order was:
1. Generate inprogress javadocs
2. Generate inprogress apidocs
3. Extract older version archives <- where everything fell apart
4. Create new releasedocs for all versions
5. Run middleman
By moving step 3 to be after step 5, changing the directory to where the
extract should actually live, changing where the inprogress javadoc should
live, and preventing overwriting the "existing" files (i.e., the changelog
info), a big chunk of this hocus pocus goes away entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
