b4n commented on this pull request.
> {
+ gint sig = GPOINTER_TO_INT(user_data);
if (sig == SIGTERM)
what about having a signal-specific callback instead of checking this?
`g_unix_signal_add()` can only get one signum at a time IIUC, so there doesn't
seem to be any reason to reuse the same handler when the body will be totally
different each time.
So I'd suggest renaming to something like `sigterm_handler()` or something, and
remove the signum check (and passing it altogether).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1255#pullrequestreview-2988792
