+1 for unhardcoding these colours, but I think it would be better to use GTK+ theming for this. The colour schemes are only supposed to affect the Scintilla editor widget. In other places where we affect the other widgets (ex. tab label colour, search entry background, etc) we already use GTK+ themes. It may even be possible to re-use the colours from GTK+ itself, like using the warning, error, info, and other colours used by GtkInfoBar, so that native dark or light GTK+ themes "just work" out of the box without having to futz with a whole other colour scheme system.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1377#issuecomment-275135349
