@attila-v Thank you for your work! I will try running Geany with this change to 
see how well it works for me.

So far I see a couple problems.

The first problem is that you still silently lose unsaved changes (in files 
that have diverged from disk).

The second problem is an assertion error. I can reproduce it as follows:

1. Open some file in Geany.
2. Delete it from disk.
3. Switch to Geany. At the top of the document, Geany shows an orange info bar 
that says: “File ... was not found on disk! Try to resave the file?”

With your change, when this orange info bar appears, I see the following in the 
console:

     GtkWarning: IA__gtk_info_bar_add_button: assertion 'button_text != NULL' 
failed

Without your change, there is no such warning.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1471#issuecomment-304460143

Reply via email to