elextr commented on this pull request.


> +                     case SC_STATUS_BADALLOC:
+                               sub_msg = "memory is exhausted";
+                               break;
+                       case SC_STATUS_WARN_REGEX:
+                               sub_msg = "regular expression is invalid";
+                               break;
+                       default:
+                               if (status >= SC_STATUS_WARN_START)
+                                       sub_msg = "unknown warning";
+                               else
+                                       sub_msg = "unknown failure";
+                               break;
+               }
+#define SCI_STATUS_FORMAT_STRING "%s:%u: scintilla has non-zero status " \
+                       "code '%d' after sending message '%u' to instance '%p' 
with " \
+                       "wParam='%lu' and lParam='%ld': %s"

Theoretically these formats should be `%p` because both wparam and lparam are 
`intptr_t`.  In reality they are the same size as long on all platforms except 
win64, and we don't currently support that AFAIK. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1572#pullrequestreview-54288711

Reply via email to