codebrainz commented on this pull request.


>       gint doc_page = document_get_notebook_page(doc);
        for (gint i = doc_page + 1; i < gtk_notebook_get_n_pages(nb); )
        {
                if (! document_close(document_get_from_page(i)))
                        i++; // only increment if tab wasn't closed
        }
-       gtk_notebook_set_current_page(nb, doc_page);
+       gtk_notebook_set_current_page(nb, MIN(current_page, doc_page));

Would've saved me a couple minutes of head-scratching if there was a comment 
that said "keep the current tab unless it was closed, in which case use the 
activated tab" or something. Maybe I'm just stupid.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1579#pullrequestreview-63410944

Reply via email to