b4n requested changes on this pull request.
I agree with @codebrainz and @elextr that the info should probably be somewhere
less intrusive than the tab label, and would also think first thing about the
status bar.
> @@ -322,6 +322,10 @@ void sci_zoom_off(ScintillaObject *sci)
SSM(sci, SCI_SETZOOM, 0, 0);
}
+gint sci_zoom_get(ScintillaObject *sci)
should probably be `sci_get_zoom()` for consistency
> @@ -954,6 +958,17 @@ void sci_set_font(ScintillaObject *sci, gint style,
> const gchar *font, gint size
}
+/** Gets the font size for a particular style.
+ * @param sci Scintilla widget.
+ * @param style The style.
+ * @return The font size. */
+GEANY_API_SYMBOL
+gint sci_get_fontsize(ScintillaObject *sci, gint style)
`sci_get_font_size()`.
Also, why is it part of the plugin API? Not that I don't want it, but we
prefer to have a good reason for adding stuff to the API so we don't have to
maintain something useless.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#pullrequestreview-78814845
