codebrainz commented on this pull request.
> @@ -389,8 +389,8 @@ markdown_viewer_update_view(MarkdownViewer *self)
* position once the webview is reloaded. */
if (self->priv->load_handle == 0) {
self->priv->load_handle =
- g_signal_connect_swapped(WEBKIT_WEB_VIEW(self), "notify::load-status",
- G_CALLBACK(on_webview_load_status_notify), self);
+ g_signal_connect_swapped(WEBKIT_WEB_VIEW(self), "notify::is-loading",
+ G_CALLBACK(on_webview_is_loading_notify), self);
Instead of the property notification, maybe it should use
[`load-changed`](https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#WebKitWebView-load-changed)?
> MarkdownViewer *self)
{
- WebKitLoadEvent load_status;
+ gboolean load_status;
Likewise, instead of using this boolean, to look for
[`WEBKIT_LOAD_FINISHED`](https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#WEBKIT-LOAD-FINISHED:CAPS)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/677#pullrequestreview-89678176
