b4n commented on this pull request.
> @@ -908,6 +908,18 @@ static gchar *get_symbol_tooltip(GeanyDocument *doc,
> const TMTag *tag)
{
gchar *utf8_name = editor_get_calltip_text(doc->editor, tag);
+ if (!utf8_name && tag->var_type &&
+ tag->type & (tm_tag_member_t | tm_tag_variable_t |
tm_tag_externvar_t))
Is the type check guarding against actual issues, or is it just being careful?
I can imagine it might be a problem with typedefs, but it might erroneously
omit `tm_tag_field_t` (not 100% sure what that is, but it's used by several
parsers, and I believe for Vala it's variable members).
Not a blocker though, we can amend this as needed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2036#pullrequestreview-189754329
