@frlan yes, its good rule at the time of _merging_ a pull request, but squashing commits along the way leads to force-pushing which can cause problems. So its not something _contributors_ should do until the PR is accepted, but ...
... (as you said) github now provides good support squashing at merge (its the default big green button) so its even less important now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2059#issuecomment-455508460
