codebrainz commented on this pull request.


> @@ -289,8 +289,8 @@ gboolean dialogs_directory_settings(WB_PROJECT_DIR 
> *directory)
        dialog = gtk_dialog_new_with_buttons(_("Directory settings"),
                                                                                
 GTK_WINDOW(wb_globals.geany_plugin->geany_data->main_widgets->window),
                                                                                
 flags,
-                                                                               
 _("_Cancel"), GTK_RESPONSE_CANCEL,
-                                                                               
 _("_OK"), GTK_RESPONSE_ACCEPT,
+                                                                               
 GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
+                                                                               
 GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,

IIRC this was part of the [Infamous Deprecations of 
2013](https://mail.gnome.org/archives/gtk-devel-list/2013-July/msg00000.html). 
I believe the issue of each project having to provide their own translations 
for each of these stock items was brought up and dismissed by GNOME designers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/842#discussion_r275169290

Reply via email to