> However, we most probably don't need to run `distcheck` on all compilers, as 
> it's mostly checking the build system itself rather than the compilation. 
> Only `all` (obviously) and `check` are really useful to run everywhere for a 
> sensible test, and that might give a comfortable speed up by not building 
> everything twice. This can be changed at some later point tho, and can 
> probably be fixed by e.g. setting `TARGETS="all check distcheck"` in the 
> "normal" case and removing `distcheck` in the "compiler builds", and 
> replacing the `make -j2 && make -j2 check && make -j2 distcheck` with just 
> `make -j2 $TARGETS`.

I pushed a commit that addresses that. But I made the change before I reviewed 
your suggested approach. If you'd like it changed, please let me know.

> 
> Anyway, the change seems a little verbose, but there might not be a shorter 
> syntax for this (I'm no YAML expert tho).

That's another copy/paste from the travis docs. afaik the only way to reduce 
the lines is to use a script that manually imports the toolchain repo and keys, 
and installs the appropriate gcc package.

However, using the the "addons/source" travis directive as it is now may be 
easier in the long-run, to maintain. What do you think?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2067#issuecomment-488541374

Reply via email to