b4n commented on this pull request.
> @@ -37,7 +112,10 @@ script:
mkdir _build &&
cd _build &&
{ ../configure $CONFIGURE_FLAGS || { cat config.log; exit 1; } ; } &&
- make -j2 &&
- make -j2 check &&
- make -j2 distcheck DISTCHECK_CONFIGURE_FLAGS="$CONFIGURE_FLAGS";
+ if [ -z "$DISTCHECK_ONLY" ]; then
+ make -j2 VERBOSE=1 -n &&
+ make -j2 check;
+ else
+ make -j2 distcheck DISTCHECK_CONFIGURE_FLAGS="$CONFIGURE_FLAGS";
+ fi;
I don't like that, because what you do is build one more time, and only that
one do the distcheck. And given how distcheck works (make the tarball and try
to build it), it could possibly be affected by the configuration options
selecting buildig or not some code (even though it should not if we didn't mess
up, but CI is to catch case where we did, isn't it :smile: ). So it is a good
thing it's checked for all variations of the environment.
Only the same environment with different compilers is not useful, because
building with another compiler shouldn't affect *what* we're building.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2067#pullrequestreview-234785015
