eht16 commented on this pull request.
> @@ -36,6 +36,10 @@ #ifdef G_OS_UNIX #include <fcntl.h> +/* The maximum length of an expression for evaluating the value. + (Including the string terminator '\0') */ +#define SCOPE_MAX_EVALUATE_EXPR_LENGTH 256 Is it intended that the macro definition is within the `#ifdef G_OS_UNIX` block? This breaks the Windows builds: https://nightly.geany.org/win32/build_win32_plugins_stderr.log as it used unconditionally later on. I assume the macro definition should be outside any OS guards? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/823#pullrequestreview-261536540
