@elextr: > these seem to be just waste of time noise Please avoid this kind of language. It sounds like you are annoyed. Obviously I do not think it is a waste of time or I would not have submitted it. I often don't submit changes I have done that aren't of clear benefit.
I have removed the second commit (and updated the PR description), to avoid making a subtle argument for it. Regarding the first: Smaller functions are easier to understand, and build_load_menu is complicated. build_load_menu has 2 top-level scope variables that aren't used by load_old_menu. load_old_menu has 4 top-level scope variables that aren't used by build_load_menu. Each function reads different groups of data. This should tell you that the code doesn't belong in one function. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2272#issuecomment-524534097
