Yay!
I agree also that the pretty name is redundant.

The result of `g_get_os_info` must be freed even it is not explicitly stated in 
the docs 
(https://gitlab.gnome.org/GNOME/glib/-/blob/master/glib/gutils.c#L1507).

Output on ArchLinux:
```
10:08:55: Geany INFO            : OS Information:
10:08:55: Geany INFO            :   Name       : Arch Linux (arch/)
10:08:55: Geany INFO            :   Pretty Name: Arch Linux
10:08:55: Geany INFO            :   Version    :  ()
```

Output on Windows 7:
```
22:50:54: Geany INFO            : OS Information:
22:50:54: Geany INFO            :   Name       : Windows (windows/)
22:50:54: Geany INFO            :   Pretty Name: Windows 7 SP17Vista SP2Vista 
SP1VistaXP SP3XP SP2XP SP1XP
22:50:54: Geany INFO            :   Version    : 7 SP17Vista SP2Vista 
SP1VistaXP SP3XP SP2XP SP1XP (7_sp17vista_sp2vista_sp1vistaxp_sp3xp_sp2xp_sp1xp)
```

The missing version on ArchLinux is OK because it's a rolling release and 
`/etc/os-release` doesn't have any VERSION key at all.
I'm not sure about the weird looking version on Windows, either it is just my 
installation or it usually looks like this ... :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2498#issuecomment-629099805

Reply via email to