@codebrainz commented on this pull request.
@elextr or anyone, can you confirm?
> @@ -455,6 +455,34 @@ static void
> on_close_documents_right_activate(GtkMenuItem *menuitem, GeanyDocume
}
+static void on_copy_basename_to_clipboard_activate(GtkMenuItem *menuitem,
GeanyDocument *doc)
+{
+ g_return_if_fail(doc->is_valid);
+
+ gchar *bname = g_path_get_basename(doc->real_path);
+ gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), bname, -1);
I could be mistaken, but I think there might be a subtle encoding bug here (and
the other two new functions).
`doc->real_path` is in "locale" encoding and `g_path_get_basename()` will spit
out "locale" encoding, but `gtk_clipboard_set_text()` is expecting the 2nd
argument to be in UTF-8 encoding. If I'm not mistaken, it might need to be
something like this (untested):
```c
gchar *bname = g_path_get_basename(doc->real_path);
gchar *utf8_bname = utils_get_utf8_from_locale(bname);
gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), utf8_bname, -1);
g_free(utf8_bname);
g_free(bname);
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2550#pullrequestreview-451025143
