@eht16 requested changes on this pull request.

GTK 3.8.2 is not the problem as we use it on all other Travis builds as well 
and they work fine.

I was able to reproduce this error with a `ubuntu:trusty` Docker container 
after replicating the steps the Travis build does. Though I don't see the cause 
for the error. My best guess is that any of the changes in `configure.ac` 
breaks the linking.

> @@ -87,8 +87,8 @@ mkdir "$BUILDDIR"
 cd "$BUILDDIR"
 
 mkdir _deps
-fetch_and_unzip "$GTK3_BUNDLE_ZIP" _deps
-[ "$GTK3" = yes ] || fetch_and_unzip "$BUNDLE_ZIP" _deps

We should keep this as is.
Even it looks weird but we need the GTK3 bundle also for GTK2 builds. IIRC 
because of a newer GLib in the GTK3 bundle.
This is why the Mingw GTK2 build failed.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2610#pullrequestreview-501546802

Reply via email to